Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-legacy): legacy sourcemap not generate (fix #11693) #11841

Merged
merged 2 commits into from
Jan 31, 2023
Merged

fix(plugin-legacy): legacy sourcemap not generate (fix #11693) #11841

merged 2 commits into from
Jan 31, 2023

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Jan 29, 2023 •
edited
Loading

Description

fix #11693

Additional context

plugin-legacy should compatible with rollup3.x: don't delete sourcemap in bundle

See rollup3.x break changes

When using the API and sourcemaps, sourcemap comments are contained in the emitted files and sourcemaps are emitted as regular assets (#4605)

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added plugin: legacy p4-important Violate documented behavior or significantly improves performance (priority) regression The issue only appears after a new release labels Jan 29, 2023
@sapphi-red
Copy link
Member

Thank you for the PR!
Would you add a test for this?

@sun0day
Copy link
Member Author

sun0day commented Jan 29, 2023

Thank you for the PR! Would you add a test for this?

Done

sapphi-red
sapphi-red approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patak-dev patak-dev merged commit 2ff5930 into vitejs:main Jan 31, 2023
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@futurGH
fix(plugin-legacy): legacy sourcemap not generate (fix vitejs#11693) (v…
1d1603c 
…itejs#11841)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p4-important Violate documented behavior or significantly improves performance (priority) plugin: legacy regression The issue only appears after a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The [name]-legacy-[hash].js file generated by vite@4.x and @vitejs/plugin-legacy does not have a sourcemap
3 participants
@sun0day @sapphi-red @patak-dev